Upgrade to generator-jhipster@6.8.0

jhipster / jhipster-vuejs

A Vue.js blueprint for JHipster. It will use Vue.js as the frontend library!

https://www.jhipster.tech

Apache License 2.0

301 stars 179 forks source link

Upgrade to generator-jhipster@6.8.0 #572

Closed pascalgrimaud closed 4 years ago

pascalgrimaud commented 4 years ago

Fix https://github.com/jhipster/jhipster-vuejs/issues/574

Please make sure the below checklist is followed for Pull Requests.
[ ] All continuous integration tests are green
[ ] Tests are added where necessary
[ ] Documentation is added/updated where necessary
[ ] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

pascalgrimaud commented 4 years ago

I can reproduce the failure locally:

in generator-jhipster: npm link
in jhipster-vuejs: npm link
in jhipster-vuejs: npm test -> it failed

Maybe you can help @mshima ?

mshima commented 4 years ago

@pascalgrimaud there are 2 possible fixes:

Remove dependency on yeoman-generator and yeoman-environment, I think they aren’t used.
Move them to dev dep and update if tests fails. Yeoman-test maybe brings an older version of them.

pascalgrimaud commented 4 years ago

thanks a lot, I'll probably try to fix it next week.

mshima commented 4 years ago

I will try to take a look tomorrow.

mshima commented 4 years ago

@pascalgrimaud tty error is a Inquirer bug related to https://github.com/SBoudrias/Inquirer.js/pull/891

Should be pinned to version 7.0.4 for now.

pascalgrimaud commented 4 years ago

@mshima : should I force the use of specific version of inquirer ? Then, in main generator, we have https://github.com/jhipster/generator-jhipster/blame/master/package.json#L103 -> 9 months ago

mshima commented 4 years ago

@mshima : should I force the use of specific version of inquirer ? Then, in main generator, we have https://github.com/jhipster/generator-jhipster/blame/master/package.json#L103 -> 9 months ago

I think we should update main to 7.0.4 too. I just created a new PR on inquirer for a new feature.

mshima commented 4 years ago

The problem only happens on inquirer + yeoman-test : https://github.com/yeoman/yeoman-test/issues/78

mshima commented 4 years ago

@pascalgrimaud 7.0.4, I think 7.0.6 didn’t fixed it. Let’s wait the CI status.

pascalgrimaud commented 4 years ago

thanks again @mshima !

pascalgrimaud commented 4 years ago

@mshima : I merged your PR, but Vue.js blueprint uses exact 6.8.0 and not master

If https://github.com/jhipster/generator-jhipster/pull/11453 is absolutely necessary, I can't release Vue.js blueprint without a patch release of generator-jhipster 6.8.1

pascalgrimaud commented 4 years ago

thanks @mshima for your help there are 2 last issues:

embedded document, for couchbase and kafka
increase coverage

pascalgrimaud commented 4 years ago

I'm merging this, as the 2 last items can be done in separate PRs

mshima commented 4 years ago

@mshima : I merged your PR, but Vue.js blueprint uses exact 6.8.0 and not master

If jhipster/generator-jhipster#11453 is absolutely necessary, I can't release Vue.js blueprint without a patch release of generator-jhipster 6.8.1

I don’t think it’s needed. This problem is old and I forgot to create a PR to fix it. https://github.com/mshima/generator-jhipster/commit/4bd86209e77ff61b7431c69fc5fa6aa0536624b2 CI succeeded now.

mshima commented 4 years ago

By the way inquirer 7.0.7 is released to fix yeoman-test.