jhipster / jhipster-vuejs

A Vue.js blueprint for JHipster. It will use Vue.js as the frontend library!
https://www.jhipster.tech
Apache License 2.0
301 stars 179 forks source link

Swagger not available #618

Closed pascalgrimaud closed 4 years ago

pascalgrimaud commented 4 years ago

Just encountered it with last version of Vue.js 1.8.0 If someone can confirm ?

I'll provide information later if needed

pascalgrimaud commented 4 years ago

The solution was found by @adilabed here: https://github.com/jhipster/jhipster-control-center/pull/64/commits/f3d096360ed954fce8726e73c044c17a1bf20668

Would you like to contribute and provide the fix here too plz ?

cc @atomfrede as it's related to the recent upgrade of webpack

adilabed commented 4 years ago

My solution is not the most elegant one. The plugin CopyWebPackPlugin doesn't exclude ./node_modules/swagger-ui-dist/index.html' when copying the files from the selection.

atomfrede commented 4 years ago

Thats strange, the globoptions are supposed to exclude the index.html, basically migrated the settings to the new structure.

https://webpack.js.org/plugins/copy-webpack-plugin/#globoptions

Can have a look, but in case there is only index.html excluding it from the from properties seems okay to me.

pascalgrimaud commented 4 years ago

Since this upgrade of webpack, the build is longer than before. Did you see the same, @atomfrede ?

atomfrede commented 4 years ago

At least locally I didn't notice, but also didn't compare.

Regarding ignore pattern, I found https://github.com/webpack-contrib/copy-webpack-plugin/issues/493

atomfrede commented 4 years ago

So maybe try globOptions: { ignore: ['**/index.html'] }, instead.

adilabed commented 4 years ago

Ok perfect, It works!!

atomfrede commented 4 years ago

Awesome, do you provide a PR here?

adilabed commented 4 years ago

Will do now.

atomfrede commented 4 years ago

@pascalgrimaud Regarding the build performance, looking at https://webpack.js.org/guides/build-performance/#specific-tooling-issues, we don't follow their recommendations for typescript. Will give it a try this week.

pascalgrimaud commented 4 years ago

@atomfrede : do you think we should do a release with this fix ? I think it's important. And as Vue.js is still in blueprint, it's really easy to release

atomfrede commented 4 years ago

Yes let's do it.