Open snitin315 opened 4 years ago
Thanks for proposing this, @snitin315 But there are still a lot of failures, specially in e2e tests. Can you have a look plz ?
@pascalgrimaud fixed :+1:, not sure about Vue.js / vuejs-fulli18n-es . all tests seem to pass there.
Last failure is related to:
Jest: "global" coverage threshold for branches (60%) not met: 59.94%
Test Suites: 98 passed, 98 total
Tests: 454 passed, 454 total
Snapshots: 0 total
Time: 52.099 s
Ran all test suites.
Maybe add another test to check all possible condition ?
@pascalgrimaud thanks, all green now :100:
Thanks @snitin315 : give me time to review and do some manual tests :)
@hdurix : as you opened the original issue, do you have time to have a quick look plz ?
Fix #482
Please make sure the below checklist is followed for Pull Requests.
[x] All continuous integration tests are green
[x] Tests are added where necessary
[x] Documentation is added/updated where necessary
[x] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed