jhipster / jhipster-vuejs

A Vue.js blueprint for JHipster. It will use Vue.js as the frontend library!
https://www.jhipster.tech
Apache License 2.0
301 stars 179 forks source link

Map all dates from server in HTTP services #632

Open snitin315 opened 4 years ago

snitin315 commented 4 years ago

Fix #482

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

pascalgrimaud commented 4 years ago

Thanks for proposing this, @snitin315 But there are still a lot of failures, specially in e2e tests. Can you have a look plz ?

snitin315 commented 4 years ago

@pascalgrimaud fixed :+1:, not sure about Vue.js / vuejs-fulli18n-es . all tests seem to pass there.

Screenshot at 2020-06-22 13-11-52

pascalgrimaud commented 4 years ago

Last failure is related to:

Jest: "global" coverage threshold for branches (60%) not met: 59.94%

Test Suites: 98 passed, 98 total
Tests:       454 passed, 454 total
Snapshots:   0 total
Time:        52.099 s
Ran all test suites.

Maybe add another test to check all possible condition ?

snitin315 commented 4 years ago

@pascalgrimaud thanks, all green now :100:

pascalgrimaud commented 4 years ago

Thanks @snitin315 : give me time to review and do some manual tests :)

pascalgrimaud commented 4 years ago

@hdurix : as you opened the original issue, do you have time to have a quick look plz ?