search

jhipster / jhipster-vuejs

A Vue.js blueprint for JHipster. It will use Vue.js as the frontend library!
https://www.jhipster.tech
Apache License 2.0
301 stars 179 forks source link

translations for falsy values : empty, 0 and false #644

Closed SoniaLahi closed 4 years ago

SoniaLahi commented 4 years ago
Overview of the feature request

In order to have a similar behaviour between frontend frameworks (cf. PR on react falsy translations), when translation key values are 0 or false, it should return the value (0, false) instead of the key.

I will fix it this week.

Motivation for or Use Case

Standardization of translation behaviours in frontend apps.

Related issues or PR

Improvement requested here : https://github.com/jhipster/react-jhipster/pull/48#issuecomment-610908160

SoniaLahi commented 4 years ago

Could you assign it to me ? Thank you

pascalgrimaud commented 4 years ago

@SoniaLahi : Vue has been merged into main generator-jhipster -> you should not work on this project, as it will be deprecated soon

SoniaLahi commented 4 years ago

Thank you @pascalgrimaud ! I have duplicated the ticket on generator-jhipster https://github.com/jhipster/generator-jhipster/issues/12529 and we can close this one.