search

jhipster / prettier-java

Prettier Java Plugin
http://www.jhipster.tech/prettier-java/
Apache License 2.0
1.08k stars 103 forks source link

Consider adding unused imports removal or java-lint package. #662

Open mshima opened 5 months ago

mshima commented 5 months ago

I've created https://github.com/mshima/java-lint to remove unused imports in generator-jhipster generated code. Would be nice if it could be moved to jhipster organization in java-parser/prettier-java repository.

murdos commented 5 months ago

I think there have already been some discussions about how far prettier-java should go with imports, in https://github.com/jhipster/prettier-java/issues/201. The conclusion - as I understand it - was that prettier is a formatter, but should not act as a linter. So this might be out of the scope of prettier.

mshima commented 5 months ago

Yes, I understand that it should be not be implemented in prettier-plugin-java. The proposal is to add a new package in this repository.

DanielFran commented 5 months ago

@clementdessoude Any thoughts on that? @mshima Since the development is already done, working and used in the generator, can you provide a PR so we can evaluate the impacts?

pascalgrimaud commented 5 months ago

I agree with @murdos : this might be out of the scope of prettier

@mshima : if you want to include this project to jhipster organization, it should be at github.com/jhispter/java-lint Just send an email to the mailing to discuss about it

mshima commented 5 months ago

I agree with @murdos : this might be out of the scope of prettier

@mshima : if you want to include this project to jhipster organization, it should be at github.com/jhispter/java-lint Just send an email to the mailing to discuss about it

I only have interest to move to the java-parser repository to keep java-lint updated with it. I don't have interest to move to jhipster organization if the structure will be kept the sample.

mshima commented 5 months ago

can you provide a PR so we can evaluate the impacts?

@DanielFran the idea is to move the entire project to https://github.com/jhipster/prettier-java/tree/main/packages/java-lint. As impact, maybe we should migrate prettier-java to vitest to match java-lint.