search

jhnns / rewire-webpack

Dependency injection for webpack bundles
The Unlicense
121 stars 20 forks source link

Fixed compatibility with latest Webpack #18

Closed RSO closed 8 years ago

RSO commented 8 years ago

As of webpack/webpack@5acfacfdd667f1a0b340f034cae6ce6c198e5c06 .Class webpack is using Dependency::constructor over Dependency::Class. I decided to keep the .Class for backwards compatibility.

Fixes jhnns/rewire-webpack#16

jhnns commented 8 years ago

Damn! I wanted to publish this tonight, but somehow I was unable to install the dependencies. npm keeps installing rewire from the npm registry instead of GitHub (and rewire on npm does not contain a test folder).

Are you able to install it? Is something wrong with my local setup or is it a npm bug?

barsukov commented 8 years ago

Thank you guys, but this package is not on npm yet. Broke every my build... Try to use direct from github

RSO commented 8 years ago

@barsukov we're using this from the Hacker0x01/rewire-webpack@master now, and it fixes our problems.

@jhnns I will investigate and see if I can reproduce.

RSO commented 8 years ago

@jhnns yeah, it seems that installing from github now also uses the .npmignore file. Not sure when this got introduced, did a quick search but couldn't find anything. If other dependencies really need files inside of the test/ folder in rewire, wouldn't it make sense to remove it from the .npmignore file?

jhnns commented 8 years ago

If other dependencies really need files inside of the test/ folder in rewire, wouldn't it make sense to remove it from the .npmignore file

Mhmm yes ... that's probably true.

jhnns commented 8 years ago

This has finally been shipped with 1.0.1 :grin: