search

jhnns / rewire

Easy monkey-patching for node.js unit tests
MIT License
3.08k stars 128 forks source link

fix(deps): upgrade eslint to fix semver vulnerability #210

Closed roggervalf closed 1 year ago

roggervalf commented 1 year ago

also I think it will solve https://github.com/jhnns/rewire/pull/207 and https://github.com/jhnns/rewire/issues/208, as new versions do not depend on semver

roggervalf commented 1 year ago

please @jhnns, when you get some chance

coveralls commented 1 year ago

Coverage Status

coverage: 98.721%. remained the same when pulling 697ff7176c4c33c416eec524ebdf34983282d575 on roggervalf:fix-semver-vulnerability into f5c655a58300f0899a0f5de130bff6e9dcf3de81 on jhnns:master.

roggervalf commented 1 year ago

this is weird, I can execute the tests locally without errors Captura desde 2023-08-10 09-23-36 also I tried to update package-lock using version 1, as it was generated with that version

roggervalf commented 1 year ago

so it's failing for node 10 because of this change https://github.com/eslint/eslint/pull/14592 base on https://github.com/eslint/eslint/issues/14023. https://community.sonarsource.com/t/drop-of-node-js-10-support-and-deprecation-of-node-js-12-support/59590 node 10 is no longer being supported, so this should be considered as a breaking change, let me update the ci to drop of node 10 as well

jhnns commented 1 year ago

Thank you for your PR. The failing tests were caused by a breaking change in the package-lock file from npm 8 to 9. I decided to remove official Node 10, 12, 14 and 16 support, as it was not possible to run the CI pipeline with this breaking change.

I made all these changes on the master branch as it was easier for me, so I'm closing this one. The ESLint update shipped with rewire v7.0.0.