search

jhoblitt / puppet-ganglia

Manages ganglia gmond & gmetad daemons + web front end
Other
12 stars 34 forks source link

unit tests should cover file content #2

Closed jhoblitt closed 9 years ago

jhoblitt commented 11 years ago

At present, the unit tests are not checking the content of the generated configuration files. This should be added to catch variable handling errors and ERB template regressions.

jhoblitt commented 9 years ago

@NoodlesNZ Adding unit test coverage of template variable interpolation as you change them may be useful. There's examples of a few different ways of checking file content in here: https://github.com/jhoblitt/puppet-smartd/blob/master/spec/unit/classes/smartd_spec.rb