search

jhoblitt / puppet-ganglia

Manages ganglia gmond & gmetad daemons + web front end
Other
12 stars 34 forks source link

Removes trailing whitespace #20

Closed g0xA52A2A closed 10 years ago

g0xA52A2A commented 10 years ago

A number of files contained trailing whitespace, this has been removed with the following perl one-liner.

perl -pi -e 's/ +$//' *

Not having whitespace prevents confusing diff outputs such as the following.

https://github.com/jhoblitt/puppet-ganglia/pull/3#discussion-diff-7579522

The diff changes on the PR may seem a bit crazy with blocks seemingly removed and re-added but if you view with the following URL or do git diff --ignore-space-at-eol you'll see it's just space removal.

https://github.com/jhoblitt/puppet-ganglia/pull/20/files?w=1

jhoblitt commented 10 years ago

I suspect the trailing w/s was largely from the original conf files but I'll go ahead and merge the entire PR. This module really needs some TLC.

jhoblitt commented 10 years ago

BTW - the email address used for the git commits doesn't seem to match your github account.

g0xA52A2A commented 10 years ago

Hey thanks for pointing that out I did this from my work where we mainly use an internal git server. Is this an issue? I'll try and keep future commits consistent with my github details.