jhoblitt / puppet-ganglia

Manages ganglia gmond & gmetad daemons + web front end
Other
12 stars 34 forks source link

Change ganglia_port default to string #32

Closed NoodlesNZ closed 9 years ago

NoodlesNZ commented 9 years ago

I looked at trying to validate ganglia_port as an integer for future parser, but it all seemed a bit hacky. I've changed the default to a string, this way it will work with both parsers. If people are using the current parser then passing in a bareword port number will still work.

jhoblitt commented 9 years ago

I apologize for the slow response -- last week was a holiday week in the US.

Did you try a strategy similar to this?

https://github.com/puppetlabs/puppetlabs-concat/blob/master/manifests/fragment.pp#L43-L45

If that doesn't work for some reason I'm happy to merge this.

NoodlesNZ commented 9 years ago

That looks like it might work. I'll look at adding some rspec tests for web later