jhoblitt / puppet-ganglia

Manages ganglia gmond & gmetad daemons + web front end

Other

12 stars 34 forks source link

Fix problem with undef override_hostname #34

Closed NoodlesNZ closed 9 years ago

NoodlesNZ commented 9 years ago

If override_hostname is not defined it uses the default of undef, but the logic in the template doesn't work as expected. I've added a failing rspec test first, which I will fix in another commit.

jhoblitt commented 9 years ago

There's no rspec tests as part of this PR?

NoodlesNZ commented 9 years ago

Yea, I failed at writing the rspec test. I wanted it to fail if override_hostname is present with the default params.

jhoblitt commented 9 years ago

Well, it's failing...

NoodlesNZ commented 9 years ago

Ok, that seems to have got it (with the Travis CI problem again).

jhoblitt commented 9 years ago

36 should work around the ruby 1.8.7 problem. Try rebasing on top of master.

NoodlesNZ commented 9 years ago

Looks like #36 did the trick, good work

jhoblitt commented 9 years ago

Could you rebase?

jhoblitt commented 9 years ago

@NoodlesNZ ping? This PR needs to be rebased so it can be merged.

NoodlesNZ commented 9 years ago

I've only just got back from vacation, so will look at this once I've caught up on emails/work.

NoodlesNZ commented 9 years ago

There you go, that should do it.

jhoblitt commented 9 years ago

Thank you again!