search

jhoblitt / puppet-ganglia

Manages ganglia gmond & gmetad daemons + web front end
Other
12 stars 34 forks source link

gmetad.conf - adding support for managing 'all_trusted' and 'trusted_hos... #48

Closed tskirvin closed 9 years ago

tskirvin commented 9 years ago

...ts'

Adds two optional parameters to gmetad.pp - 'all_trusted' (a boolean, default false), and 'trusted_hosts' (array of strings, default empty). These can be used to populate the corresponding fields in gmetad.conf.

Includes a spec file check for these parameters as well, though I haven't tested that adequately yet.

tskirvin commented 9 years ago

Should be good to go now. The future parser is still griping, but not about changes I made (as far as I can tell).

jhoblitt commented 9 years ago

Thank you for putting effort into this!

I believe it was complaining before this PR about a change in undef behavior inside of ERB that I haven't fuly run down (I think it happened around 3.7.1). I'll merge this today after an acceptance test run.

jhoblitt commented 9 years ago

Also, would you add the the new params to the README? Hopefully, we'll be living in the future were the puppet docs are marchine generated soon but we're not there yet.

tskirvin commented 9 years ago

Joshua Hoblitt notifications@github.com writes:

Also, would you add the the new params to the README? Hopefully, we'll be living in the future were the puppet docs are marchine generated soon but we're not there yet.

    Done.

                       - Tim Skirvin (tskirvin@killfile.org)

http://wiki.killfile.org/ Skirv's Homepage < <*> http://www.facebook.com/tskirvin Skirv's Social Networking

jhoblitt commented 9 years ago

It passed an acceptance test run. Thank you for contributing!