jhoblitt / puppet-ganglia

Manages ganglia gmond & gmetad daemons + web front end
Other
12 stars 34 forks source link

ganglia::udp_send_channel, etc as resources? #5

Closed kitchen closed 4 years ago

kitchen commented 10 years ago

What are your thoughts on having ganglia::udp_send_channel and such resources?

I would love to be able to have my collector gmonds export a udp send channel that my senders use, and have them also export clusters to gmetad, etc.

I'll do the work, and I figure we can just use like /etc/ganglia/conf.d/ sort of thing to bring in the configs so there won't even need to be any changes to the core configs (or anything silly like concat or whatever)

Thoughts?

Btw, great module, thanks for providing it!

jhoblitt commented 10 years ago

I don't have an inherent objection. The config file format is fairly complicated so I'm not sure if a type per file directive or supporting config file snippets in a conf.d dir is the right way to go. The datacat module might be a reasonable way of going about keeping the configuration in one central file. Do you have a sense of what's common in ganglia installs these days? Are folks moving towards conf.d?

kitchen commented 10 years ago

well, each section is pretty straightforward and the default templates already include a conf.d directory.

As far as datacat is concerned, I'd probably want to standardize around using puppetlabs/concat if I were going that route, but I think managing the conf.d directory fully and then managing the files within would be the better way to go. I don't really think of "what people are doing" in config files, more of "what works best for puppet", and having one file per resource would be better, imo. The various concat modules are all fairly decent but all fairly poor, and having Yet Another Concat Module dependency is a Bad Thing, imo.

I'll put something together and fire it over and we can discuss it. I'll make sure the existing module parameters and such are supported, of course.

jhoblitt commented 10 years ago

The stock gmond.conf from the el5 gmond package, which is frustratingly old (3.0.7), does not have an include attribute in it. The man page from that version says it does support include but we'd need to double check that it works with a wildcard, if going that way.

datacat is substantially different than puppetlabs/concat in terms of how it functions but both are in the same problem space, I'm actually a repo collab on the later. :) While concat details with literal file fragments, datacat deals with hashes, which it merges before passing to a template. PL concat is great for file snippets while datacat is a means of building up a single data structure. I'm not arguing for datacat's use here, just pointing it out since it's new and most are not familiar with it yet.

g0xA52A2A commented 10 years ago

Hey, I'd like to pick this up! Is the conf.d / include ability on el5 still an issue? The README states el5 is currently supported but I'm not sure how many people are still require this compatibility. Just wanted to double check before starting as @kitchen states I think individual files would be cleaner than managing file fragments.

jhoblitt commented 10 years ago

Well, I for one still need EL5 support. :)

g0xA52A2A commented 10 years ago

Ha, ok I'll spin up a CentOS 5 VM and see what the situation is with includes.

jhoblitt commented 4 years ago

FYI - el5 support has been dropped from this mod.

kitchen commented 4 years ago

I haven’t used this puppet module in 7 years, I’ll close this issue ;)