search

jhoblitt / puppet-ganglia

Manages ganglia gmond & gmetad daemons + web front end
Other
12 stars 34 forks source link

stdlib ensure_package? #66

Open jcpunk opened 8 years ago

jcpunk commented 8 years ago

Should the package{} items be shifted to ensure_package from stdlib?

jhoblitt commented 8 years ago

That wouldn't hurt but using ensure_package() instead of ensure_resources() is dependent on whether or not the allow_virtual param can be removed. I believe that was added to silence a warning introduced in puppet 3.6.x, that has since been removed. Eg

https://github.com/jhoblitt/puppet-ganglia/blob/7ad4f413302aae66dbc6fe96980f8a10fea574f6/manifests/web.pp#L18

jhoblitt commented 4 years ago

allow_virtual has been removed but the ensure param is now being used. A PR to convert to ensure_resources() would be welcome.