search

jhoblitt / puppet-ganglia

Manages ganglia gmond & gmetad daemons + web front end
Other
12 stars 34 forks source link

Add params for optional gmond-python (by default not installed) #77

Closed jcpunk closed 4 years ago

jcpunk commented 7 years ago

This PR adds the option to also install the gmond-python package if you desire. Two params were added to ganglia::gmond to permit installation of the optional python libraries.

By default they are not installed to preserve existing behavior.

jhoblitt commented 6 years ago

Ugh - the travis / unit testing config needs TLC.

jhoblitt commented 4 years ago

@jcpunk Are you still using this mod?

jcpunk commented 4 years ago

I am. I'm actually still using the old version this patch applied against. It met my needs so I didn't update the module when you pushed new versions.

frizop commented 4 years ago

Ok, so this is kinda interesting in that we do param checking for the following:

Variant[String, Tuple] $gmond_package_name        = $ganglia::params::gmond_package_name,

so you can pass a single string in there, or a ['package1', 'package2'] and some of the tests iirc, do catch that. Let me see if I can figure out which one it is.

frizop commented 4 years ago

gmond_spec.rb:119 should cover multiple package names https://github.com/jhoblitt/puppet-ganglia/spec/classes/gmond_spec.rb#L119

frizop commented 4 years ago

yeah, I don't think we need this unless we want to call out a totally separate class param for extra packages... I'm not totally opposed to including something like, 

Array $extra_packages = $ganglia::params::extra_packages

with a default value of []

Edit: but I'd rather not take a PR that breaks tests and all that