search

jhoblitt / puppet-ganglia

Manages ganglia gmond & gmetad daemons + web front end
Other
12 stars 34 forks source link

Renewing Puppet Forge Approved Status #80

Closed lionce closed 4 years ago

lionce commented 5 years ago

Hey @jhoblitt,

Here at puppetlabs, we are currently going through all of our Approved modules on the Puppet Forge. We have some feedback for your module if you would be interested in retaining the approved status. If you are keen on keeping your approved status please ensure you respond as soon as you possibly can.

Many Thanks The Puppet Approvals Committee.

jhoblitt commented 5 years ago

Please!

lionce commented 5 years ago

Hello @jhoblitt ,

Thank you for your prompt reply. In order for this module to remain approved, the following areas need to be updated: • Add Puppet 5+6 support • README should conform to documentation standards (see here) • Module should be under active maintenance (within last 6 months)

For additional information on Puppet Forge Approved criteria please see here.  Thank you for your cooperation. If you have any questions or concerns, don’t hesitate to let me know.

Cheers!

frizop commented 4 years ago

Howdy @lionce just wondering now that there's some new modern code in this repo what the status will be updated to be? I'll note for both @jhoblitt and myself, the README.md seems a bit dated now (but most info is still accurate) and we should work on updating it. I'll also note to @jhoblitt we should look into doing a release soon, ie: the whole reason I did the work on this module :100:

jhoblitt commented 4 years ago

I'm planning to cut a new major release that drops puppet < 5 and el5 soonish.

jhoblitt commented 4 years ago

I'm currently experiencing rake target rage trying to get travis deployment to the forge up and running...

frizop commented 4 years ago

w00t, looks like you figured it out? I'm just now getting back to this, looks like testing is all valid locally and I see a forge release :tada:

jhoblitt commented 4 years ago

Yes, finally, the pdk generated .travis.yml isn't in a working state out of the box and the template isn't very flexible but it seems to be finally working. https://forge.puppet.com/jhoblitt/ganglia/3.0.3/readme is the version that finally made it to the forge.