search

jhoblitt / puppet-ganglia

Manages ganglia gmond & gmetad daemons + web front end
Other
12 stars 34 forks source link

PDK Convert & Some tests passing on Puppet 6 #84

Closed frizop closed 4 years ago

jhoblitt commented 4 years ago

I really appreciate the effort that's going into this PR. Could someone explicitly ping me when it is ready for merge in case I miss the title being updated?

frizop commented 4 years ago

@jhoblitt no problem, just pinging you now that all tests pass! Quite welcome on the effort.

EDIT: Solved the older EL5 version issues

frizop commented 4 years ago

Alright, I think that's it. @jhoblitt I did end up doing some more to the module to clean things up like added @param options to the class docs. I accidentally wiped out your previous commit/PR (and then added the stuff back in) as follows:

commit 9460bdc70bfb4ca831d7fe57154fcb73c792fb08
Author: Rike-Benjamin Schuppner <rikebs@debilski.de>

So I just pushed up a cherry-pick to make sure that it is contained in the repo. Apologies for that.

jhoblitt commented 4 years ago

I would be fine with making a major version bump and dropping anything older than rhel/centos 7.

jhoblitt commented 4 years ago

@frizop I'll take a detailed look once CI passes. Could I ask you to do a rebase to remove the merge commit?

frizop commented 4 years ago

@frizop I'll take a detailed look once CI passes. Could I ask you to do a rebase to remove the merge commit?

Sure thing. Give me a minute and I'll push that up

frizop commented 4 years ago

Sadly I had to force push again because that merge got involved. Let me know if this looks good for you @jhoblitt EDIT: cry more tests are failing now...

jhoblitt commented 4 years ago

This looks great. Thank you for putting all the effort into this!