search

jhoblitt / puppet-selenium

Manages Selenium Server 2 - Standalone and Grid
Other
20 stars 49 forks source link

Explicitly declare service type - fails otherwise on CentOS 6.4 in some ... #1

Closed xiankai closed 10 years ago

xiankai commented 10 years ago

I was trying to use your module for my CentOS 6.4 installation, but somehow Puppet tried to start it via service seleniumserver start instead. Since your implementation uses the init provider explicitly, this change got it to work for me instead of relying on Puppet's auto-detection.

jhoblitt commented 10 years ago

This module was developed largely on centos 6.4. What version of puppet are you using?

xiankai commented 10 years ago

I was using Puppet 3.1.1, however I am unable to reproduce the issue again. Would it still be a good idea to declare the service provider?

jhoblitt commented 10 years ago

@xiankai I don't think it should be necessary. I also believe service seleniumserver start|stop|restart should work with the init script, so both the init and service provider should be able to start|stop the daemon.

How about we close this PR and you may reopen it if you can reproduce the issue?

xiankai commented 10 years ago

Okay, sounds good to me.