jhoblitt / puppet-selenium

Manages Selenium Server 2 - Standalone and Grid
Other
20 stars 49 forks source link

Debian support #41

Closed jshholland closed 9 years ago

jshholland commented 9 years ago

This is based on #17 with one small change to make the tests pass. Thanks to @dig412 for doing the hard work!

jhoblitt commented 9 years ago

Looks like the unit tests need to be changed. Did you run the acceptance tests?

jshholland commented 9 years ago

If you mean "did I run rake spec", then yes. If not, no.

jhoblitt commented 9 years ago

I was referring to rake beaker. Don't worry about it. Once you fixup the test failure I'll take a look. Thanks for working on this.

jshholland commented 9 years ago

I changed the tests so that rake beaker passes with the default nodeset, as well as Ubuntu 14.04 and Debian 7.3.

jhoblitt commented 9 years ago

@jshholland Thanks for bringing this together! There were a few minor issues which I fixed up and merged as #42.

dig412 commented 9 years ago

Thanks for sorting this out everyone!

jhoblitt commented 9 years ago

Indeed. Many thanks to all! https://twitter.com/jhoblitt/status/602678874086899714