search

jhoblitt / puppet-selenium

Manages Selenium Server 2 - Standalone and Grid
Other
20 stars 49 forks source link

Passing the timeout as parameter for Selenium class #5

Closed colferai closed 10 years ago

colferai commented 10 years ago

Dear Sir, I had problems with the timeout 90sec to download the package. I have included the timeout as a parameter for Selenium class.

Regards, Rogério

jhoblitt commented 10 years ago

This looks reasonable -- thank you for contributing. Travis failed due to lint errors. Could you fix those and repush?

colferai commented 10 years ago

Hi Joshua,

Done!

thank you!

Rogério Prado Colferai CPqD - Gerência de Tecnologia da Informação e Comunicação Tel.: +55 19 3705-6659 colferai@cpqd.com.br www.cpqd.com.br

2014/1/16 Joshua Hoblitt notifications@github.com

This looks reasonable -- thank you for contributing. Travis failed due to lint errors. Could you fix those and repush?

— Reply to this email directly or view it on GitHubhttps://github.com/jhoblitt/puppet-selenium/pull/5#issuecomment-32492534 .

jhoblitt commented 10 years ago

@colferai Thank you again. Note that I added the new param to the README and a couple of simple rspec tests. I will make a '0.2.0' release to the forge that include your PR shortly.

jhoblitt commented 10 years ago

0.2.0 has been released on the forge: http://forge.puppetlabs.com/jhoblitt/selenium/0.2.0