[logrotate_rule_non_int]

jhoblitt / puppet-selenium

Manages Selenium Server 2 - Standalone and Grid

Other

20 stars 49 forks source link

[logrotate_rule_non_int] #67

Closed khdevel closed 5 years ago

khdevel commented 8 years ago

changed the value 'rotate' in manifests/init.pp from STRING to INT as rodjek/puppet-logrotate requires
form 'rodjek/puppet-logrotate': "rotate - The Integer number of rotated log files to keep on disk (optional)."
it causes an error on puppet 3.8 with parser=future

modified: manifests/init.pp

jhoblitt commented 8 years ago

I've kicked the travis build. The failures were all because of docker timeouts.

khdevel commented 8 years ago

OK, no problem. Please test my proposition of change. BTW... why you do not use approved module for logrotate: https://forge.puppet.com/yo61/logrotate ? It is quite new and I think more stable than the old one from rodjek/logrotate. Please consider the change :)

jhoblitt commented 5 years ago

Resolved by #76