remove shell_config type/module dep

[solarkennedy]

How about this instead?

augeas { "enable_smartd":
  context => "/files/etc/default/smartmontools",
  changes => "set start_smartd yes",
}

(augeas is my new favorite puppet type apparently?)

[jhoblitt]

I'm not a Debian/Ubuntu user but I don't think messing with /etc/default/* is nessicary. The service type should deal with enabling LSB init scripts: https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/service/debian.rb

[solarkennedy]

Na, its not an init script. /etc/default is analogous to /etc/sysconfig.

[jhoblitt]

Yes, I know. And it shouldn't be necessary to mess with it to get the service to start on boot.

[jhoblitt]

ugh, the smartmontools init script checks for it though... that is ridiculous.

[lamawithonel]

Any decision on this? All shell_config does is this:

augeas { "shell_config_start_smartd":
  lens    => 'Shellvars.lns',
  incl    => /etc/default/smartmontools,
  changes => 'set start_smartd "yes"',
}

Or in the case of $file_ensure == absent,

augeas { "shell_config_start_smartd":
  lens    => 'Shellvars.lns',
  incl    => /etc/default/smartmontools,
  changes => 'remove start_smartd',
}

I can write up an alternate PR, if you need.

[jhoblitt]

@lamawithonel That would be fantastic!

[jhoblitt]

superseded by #47