Fix $service_name in Debian distributions to use 'smartmontools'

jhoblitt / puppet-smartd

Manages the smartmontools package including the smartd daemon

Other

14 stars 24 forks source link

Fix $service_name in Debian distributions to use 'smartmontools' #32

Closed TheLQ closed 10 years ago

TheLQ commented 10 years ago

The service has been called smartmontools in Debian for a while but the module by default calls it smartd.

See /etc/init.d/smartmontools in: https://packages.debian.org/wheezy/amd64/smartmontools/filelist https://packages.debian.org/sid/amd64/smartmontools/filelist http://packages.ubuntu.com/lucid/amd64/smartmontools/filelist http://packages.ubuntu.com/trusty/amd64/smartmontools/filelist

jhoblitt commented 10 years ago

@LordQuackstar Travis is failing because this PR uses whitespace that doesn't pass puppet-lint. Also, are you willing to add rspec coverage?

TheLQ commented 10 years ago

Got the tabs fixed but I don't know enough ruby to fix the tests and compile. The hardest part is spec/classes/smartd_spec.rb which hardcoded smartd as the service name. spec/system/smartd_spec.rb looks relatively easy to fix.

Sorry for not being able to help with that.