search

jhoblitt / puppet-smartd

Manages the smartmontools package including the smartd daemon
Other
14 stars 24 forks source link

Manage smartd service and don't attempt to stop if package is absent #43

Closed queeno closed 9 years ago

queeno commented 9 years ago

The smartd service resource has been wrapped in an if statement and controlled by the $manage_service parameter, so that a user of the module can choose manage the service externally.

If the smartd package is not installed, puppet will attempt to stop a service that doesn't exist. For this reason, I believe the smartd service should not be managed if $ensure is set to absent or purged.

In fact, if smartd is getting uninstalled, the deb script will take care to stop the service anyway.

jhoblitt commented 9 years ago

@queeno This looks reasonable -- are you willing to take a stab at updating the unit tests?

queeno commented 9 years ago

@jhoblitt Unit tests fixed ;-) Thanks for your quick response!