search

jhoblitt / puppet-smartd

Manages the smartmontools package including the smartd daemon
Other
14 stars 24 forks source link

Major spec cleanup #51

Closed lamawithonel closed 7 years ago

lamawithonel commented 8 years ago

I was going to add some new functionality, but the spec tests were a little hard to follow and a lot of the platform-dependent tests only included contexts for RedHat. I ended up doing a pretty massive overhaul and this is the result. Most of the work is in aeb57a5, the other commits are just in support of it. The coverage should be just as good, if not better than it was before. It also includes some changes for RuboCop. Let me know if you want anything changed.

jhoblitt commented 8 years ago

Awesome! I will take a look after travis finishes.

jhoblitt commented 8 years ago

Whoa! This is fantastic. I've made a few minor comments.

lamawithonel commented 8 years ago

Have you had a chance to review this? I addressed the issues you brought up, but I've been away for a few weeks. I'm now using it in production with #52 if it makes any difference.

lamawithonel commented 8 years ago

The last merge made most of my previous changes really difficult to rebase and I pretty much have to rewrite it. For now I'm going to scale this PR back so it can get merged more quickly. I will open other PRs for the other changes. This PR now just covers the Transpec deprecation cleanup and RuboCop support.

jhoblitt commented 7 years ago

Sorry for being asleep at the wheel here! I'm going to merge this before I tackle the rspec rot. Thanks!