Add the ability to set deamon command line options

[lamawithonel]

This adds the parameter smartd_opts to set the command line options for smartd(8) using an Augeas resource and the boolean parameter manage_smartd_opts to toggle the behavior. By default smartd_opts contains options that will save disk state and attributes to /var/lib/smartmontool, except where SELinux restricts write access. To maintain backwards compatibility, however, manage_smartd_opts is set to false by default.

This is based off PR #51, so it includes all those other commits. The only difference is 4298dd1. Other than the tests, It could probably be rebased, if needed.

New parameters:

• smartd_opts
• manage_smartd_opts

New resources:

• Augeas['smartd_opts']
• File['/var/lib/smartmontools']

[jhoblitt]

@lamawithonel Sorry for the slow maintenance activity. Could you rebase on current master?

[lamawithonel]

Do you want any of the spec_cleanup changes?

[sammcj]

I'm looking at using this module but it seems like it hasn't been maintained for some time.

@lamawithonel is this still an issue?

[lamawithonel]

I've rebased the manifest changes onto the current master branch, but the spec tests were a conflict nightmare and pretty much need to be rewritten. I had to force-push due to the conflicts, but the original spec tests are available at 4298dd1 if anyone wants to tackle that. It's not a priority for me right now.

[sammcj]

Thanks for doing that!

-- Sam McLeod

On 5 Jun 2018, at 07:48, Lucas Yamanishi notifications@github.com wrote:

I've rebased the manifest changes onto the current master branch, but the spec tests were a conflict nightmare and pretty much need to be rewritten. I had to force-push due to the conflicts, but the original spec tests are available at 4298dd1 if anyone wants to tackle that. It's not a priority for me right now.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.