search

jhoerr / posh-gitflow

A set of scripts to incorporate PoSH GitFlow extensions with posh-git, the PowerShell environment for git.
26 stars 8 forks source link

Ability to install withut Github desktop app installed #10

Open ielcoro opened 9 years ago

ielcoro commented 9 years ago

As talked in #8 it has been difficult to make posh-gitflow work without GitHub desktop installed. This pull request adds support for installing without GitHub desktop, allowing to be use with official installations of git for windows.

The flow first searches for known git environment variables, if not found tries to look for a Github desktop installation as before. It allows the user to override the search logic, by passing the git installation path as paremeter.

JacobIU commented 9 years ago

A quick question about the logic flow here -- it looks like this installs into either the global git install or all of the versions of portable git (however many there are). Should it installs into global git + portable git if both exist?

ielcoro commented 9 years ago

You are right, it installs either into the global got installation or the github installation. As posh-got flow is a command line utility I thinked that inside the command line, global got would take preference, as it's exposed through environment variables.

However, if it's is possible to launch a shell from github desktop that ignores the global git installation, modifying the logic flow to install in both locations if they are found, could make sense. It's being a while since I used github desktop though...

Anyway searching for both locations looks like an easy change.

ielcoro commented 9 years ago

Any thoughts?

Should I change the logic?