search

jholtom / webvirt

WebVirt - LibVirt web managment.
Other
5 stars 1 forks source link

Remove websockify #7

Open pefoley2 opened 11 years ago

pefoley2 commented 11 years ago

The whole websockify mess should really be replaced with a better implementation.

csssuf commented 11 years ago

We've already gone over this. NoVNC is not the issue. It's websockify that's the problem, and you're assuming the two are one and the same. websockify will be eliminated; we only needed it due to the unique problem of the Hackathon network setup. Ideally there should be no need for websockify as noVNC will be able to connect to the machine it is running on, i.e., the machine that is also running libvirt.

pefoley2 commented 11 years ago

I tried to get noVNC working without websockify and it appears to be mandatory whether it's running on the same machine or not. Take a look at http://www.ovirt.org/Features/noVNC_console and http://git.qemu.org/?p=qemu.git;a=commit;h=7536ee4bc3da7e9b7fdadba5ba6ade63eaace430 .

pefoley2 commented 11 years ago

also http://www.mail-archive.com/libvir-list@redhat.com/msg76438.html

pefoley2 commented 11 years ago

So, I've poked around a bit and haven't managed to get it working yet. Feel free to take a look, but in the meanwhile we may just subprocess.call() websockify.

michaelsmithxyz commented 11 years ago

For a less hacky method, I would note that libvirt supports console access in many forms, including but not limited to, named pipes, Unix domain sockets, pts devices TCP sockets, and plain text files .