search

jhomlala / alice

HTTP Inspector for Flutter. Allows checking HTTP connections with UI inspector.
526 stars 228 forks source link

chore: update `AliceChopperInterceptor` to be compatible with Chopper v8.0.0 #180

Closed techouse closed 1 month ago

techouse commented 1 month ago

Hey 👋

Recently I stumbled upon this awesome package and I noticed it (also) uses Chopper Interceptors.

In Chopper v8.0.0, there was a significant restructuring of interceptors. The RequestInterceptor and ResponseInterceptor classes, as well as their function counterparts, were removed.

Since I'm one of the maintainers of Chopper I thought I'd contribute to this library by updating the AliceChopperInterceptor to be compatible with Chopper v8.0.0.

CC / @Guldem

jhomlala commented 1 month ago

Hi everyone! I've just released new version of Alice which splits clients into separate packages. There's new alice + chopper package here: https://github.com/jhomlala/alice/tree/master/packages/alice_chopper . I've updated chopper to 8.0.0 in this package. Can you verify if we are aligned with our changes?

Guldem commented 1 month ago

Hi everyone! I've just released new version of Alice which splits clients into separate packages. There's new alice + chopper package here: https://github.com/jhomlala/alice/tree/master/packages/alice_chopper . I've updated chopper to 8.0.0 in this package. Can you verify if we are aligned with our changes?

Very nice improvement of splitting into different packages ❤️. Looking at the interceptor code I think the implementation of @techouse is a bit cleaner. So I would suggest aligning these changes 😄

Also we still have an open question about the alice_token and hashcode implementation if that's still relevant with the updated chopper interceptor functionality.

Thanks for all your work!

techouse commented 1 month ago

Hi everyone! I've just released new version of Alice which splits clients into separate packages. There's new alice + chopper package here: https://github.com/jhomlala/alice/tree/master/packages/alice_chopper . I've updated chopper to 8.0.0 in this package. Can you verify if we are aligned with our changes?

Very nice improvement of splitting into different packages ❤️. Looking at the interceptor code I think the implementation of @techouse is a bit cleaner. So I would suggest aligning these changes 😄

Also we still have an open question about the alice_token and hashcode implementation if that's still relevant with the updated chopper interceptor functionality.

Thanks for all your work!

Ha, looks like I jumped the gun on this one 😂 I'll check out the changes in the evening.

Guldem commented 1 month ago

Hi everyone! I've just released new version of Alice which splits clients into separate packages. There's new alice + chopper package here: https://github.com/jhomlala/alice/tree/master/packages/alice_chopper . I've updated chopper to 8.0.0 in this package. Can you verify if we are aligned with our changes?

Very nice improvement of splitting into different packages ❤️. Looking at the interceptor code I think the implementation of @techouse is a bit cleaner. So I would suggest aligning these changes 😄 Also we still have an open question about the alice_token and hashcode implementation if that's still relevant with the updated chopper interceptor functionality. Thanks for all your work!

Ha, looks like I jumped the gun on this one 😂 I'll check out the changes in the evening.

Haha, nah it just moved somewhere else 😉

techouse commented 1 month ago

This PR is a mess because of the recent changes. I have created #185 to supersede it.

jhomlala commented 1 month ago

Thanks!