search

jhomlala / alice

HTTP Inspector for Flutter. Allows checking HTTP connections with UI inspector.
544 stars 246 forks source link

fix: alice_chopper interceptor #185

Closed techouse closed 3 months ago

techouse commented 4 months ago

This PR supersedes #180

Hey 👋

Recently I stumbled upon this awesome package and I noticed it (also) uses Chopper Interceptors.

In Chopper v8.0.0, there was a significant restructuring of interceptors. The RequestInterceptor and ResponseInterceptor classes, as well as their function counterparts, were removed.

Since I'm one of the maintainers of Chopper I thought I'd contribute to this library by updating the AliceChopperInterceptor to be compatible with Chopper v8.0.0.

CC / @Guldem

✅ I tested the provided Alice Chopper example on an Android Simulator.

techouse commented 4 months ago

Can you please throw an eye on this once you can @jhomlala 🙏

CC / @Guldem

techouse commented 4 months ago

Expect I still have the same questions about the alice_token headers thats added when making the hashcode of the request.

Yeah, I kept it in because I'm not 100% sure it can be dropped. @jhomlala can probably shed some light on it.

Guldem commented 4 months ago

Expect I still have the same questions about the alice_token headers thats added when making the hashcode of the request.

Yeah, I kept it in because I'm not 100% sure it can be dropped. @jhomlala can probably shed some light on it.

Just reminding every one ^^

jhomlala commented 3 months ago

I think alice token can be removed - it's deprecated. I'll merge this PR and fix it with another PR. Thanks!

Edit: My bad, alice token can't be removed because it's needed for differentiate similiar http calls. I need to leave it as it is.