Feat/translation - Githubissues

jhomlala / alice

HTTP Inspector for Flutter. Allows checking HTTP connections with UI inspector.

544 stars 246 forks source link

Feat/translation #206

Closed jhomlala closed 3 months ago

jhomlala commented 3 months ago

Changelog:

Added AliceTranslations class which acts as translation registry. We can't use localization delegate because we're not using MaterialApp widget.
Added context.i18n extension to access translations
Added tests

jhomlala commented 3 months ago

@techouse Could you check it please?

techouse commented 3 months ago

Looks good at first glance, I just wonder why you didn't opt for something like https://pub.dev/packages/easy_localization and JSON files.

jhomlala commented 3 months ago

I'm trying to not using deps for problems which I can easily handle. Less deps = more maintainable code. Also easy_localization requires using assets which could be hard in package.

techouse commented 3 months ago

LGTM then :)