search

jhomlala / alice

HTTP Inspector for Flutter. Allows checking HTTP connections with UI inspector.
544 stars 246 forks source link

chore: refactor CI #220

Closed techouse closed 3 months ago

techouse commented 3 months ago

Facelift the CI a bit.

I'm not sure this needs subosito/flutter-action to be honest. It can probably work with dart-lang/setup-dart

Melos needs Flutter 🤪

jhomlala commented 3 months ago

Why not using install-tools.sh? It duplicates configuration. Is this intended?

techouse commented 3 months ago

The only time you should do that is when you use a reusable workflow, e.g.

jobs:
  test:
    uses: ./.github/workflows/test.yml
    secrets: inherit

Using a shell script like this is dirty because it does nothing special. I'd understand if it were some bash function that's hard to read in YAML or something similar to what mono_repo generates but this isn't that.

Is this intended?

Kinda. It's explicit.

jhomlala commented 3 months ago

Okay, now it makes sense 👍