search

jhomlala / betterplayer

Better video player for Flutter, with multiple configuration options. Solving typical use cases!
Apache License 2.0
919 stars 981 forks source link

[FIX] Remove AVMutableVideoComposition as it was causing black screen… #1115

Open marioloko opened 1 year ago

marioloko commented 1 year ago

Remove AVMutableVideoComposition as it was causing black screen iOS on simulator.

Closes #1029. This commit has been tested by several people in the thread.

The main objective of AVMutableVideoComposition was to prevent black screen on physical devices by correcting the tranform of the video track, probably it is not required anymore as we are using UIView with AVPlayerLayer instead of textures. This commit removes the change of video track transform for both physical device and iOS simulator, taking the assumption that the change of transform was only required by AVPlayerItemOutput.

utpal-barman commented 1 year ago

@marioloko great finding, this PR should be approved @jhomlala it's been a long time ios simulator is showing a black screen

SurajLad commented 1 year ago

@jhomlala can you please check, we need this fix in plugin. @marioloko great work and thanks for fix 👍

user-23xyz commented 1 year ago

@jhomlala ma buddy how is it going we need yo help

Projecthubdev commented 1 year ago

Wow lol great fix let me try to check