search

jhomlala / catcher

Flutter error catching & handling plugin. Handles and reports exceptions in your app!
Apache License 2.0
784 stars 175 forks source link

Make catcher great again! #234

Open ThexXTURBOXx opened 1 year ago

ThexXTURBOXx commented 1 year ago

This has now been released as part of catcher_2

You can use it like this:

dependencies:
  catcher_2: ^1.0.0-alpha.0

For future changes, feel free to migrate to my continuation of this project, now known as catcher_2!

Related stuff

This PR fixes many current issues in the implementation and updates the package and example dependencies.

Fixes #209 Fixes #213 Fixes #230 Fixes #232 Fixes #238 Closes #211 Closes #239 Closes #241 Closes #242 Closes #244 Closes #245 Fixes #247 Fixes #248 Fixes #249 Fixes #254 Closes #255 Fixes #257 Fixes #258 Closes #259

l-giza commented 1 year ago

@ThexXTURBOXx could you also bump "fluttertoast" reference to 8.1.1? This would remediate its issues with gradle >= 1.5.x

ThexXTURBOXx commented 1 year ago

@l-giza fluttertoast should already allow 8.1.1 because of its ^ modifier

l-giza commented 1 year ago

Ah, makes sense. Thanks!

l-giza commented 1 year ago

@jhomlala Are there chances to get this PR merged and released soon? It stops me from upgrading my project to Gradle > 1.5. Thanks!

ThexXTURBOXx commented 1 year ago

catcher 0.7.0 should already support fluttertoast 8.1.1

narumi147 commented 1 year ago

can I merge it into my folk?

ThexXTURBOXx commented 1 year ago

@narumi147 Of course :)

narumi147 commented 1 year ago

Thanks! merged.

ThexXTURBOXx commented 1 year ago

I have updated the description and title of this PR in order to reflect the new changes... It is worth mentioning that catcher will not work anymore in Flutter 3.10. This PR includes a fix for that.

calcitem commented 1 year ago

Dear @jhomlala,

First of all, thank you for creating this incredibly useful library, Catcher. Recently, I noticed that the project has not been maintained for quite some time. I found that @ThexXTURBOXx has submitted a pull request (#234) addressing several issues and updating dependencies, making Catcher compatible with the latest Flutter version.

Considering the value this PR brings to the project, I kindly request you to review and merge it if possible. If you're unable to maintain the project yourself due to time constraints or other reasons, please consider adding active contributors like @ThexXTURBOXx to the list of collaborators or allowing them to start a Catcher2 project.

This would ensure that the project stays up-to-date and continues to benefit the community. Your contributions have been greatly appreciated, and we hope to see the project thrive with your help or the help of new collaborators.

Thank you for your understanding and support.

Best regards, Calcitem

mrclauss commented 1 year ago

Hey @ThexXTURBOXx , I tried using your fork, but run into a build issue on android:

D:\workspace\contactual\flutter-app\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java:24: error: cannot find symbol flutterEngine.getPlugins().add(new com.jhomlala.catcher.CatcherPlugin()); ^ symbol: class CatcherPlugin location: package com.jhomlala.catcher D:\workspace\contactual\flutter-app\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java:69: error: cannot find symbol flutterEngine.getPlugins().add(new io.github.ponnamkarthik.toast.fluttertoast.FlutterToastPlugin()); ^ symbol: class FlutterToastPlugin location: package io.github.ponnamkarthik.toast.fluttertoast 2 errors

FAILURE: Build failed with an exception.

Any clue what's wrong there? Before I start digging deeper into this...

ThexXTURBOXx commented 1 year ago

That's weird. Did you maybe try a flutter clean? Sometimes, that helps wonders :)

mrclauss commented 1 year ago

That's weird. Did you maybe try a flutter clean? Sometimes, that helps wonders :)

Indeed, that worked. Well, I'm not surprised, there's odd things going on quite a lot in the flutter android build all the time :)

Thank you very much!

ThexXTURBOXx commented 1 year ago

No problem, nice to hear! :)

fredgrott commented 1 year ago

I would be nice to have this very useful PR merged since I am writing a full catcher usage guide based on this PR.

MOPineyro commented 1 year ago

Any chance this will be merged in soon? See the example project is what is failing CI.

ThexXTURBOXx commented 1 year ago

@MOPineyro The example project is not failing the CI. The CI was just outdated at the time of it running through, so it could not install the newest version of Flutter properly

ThexXTURBOXx commented 1 year ago

CI has been fixed by migrating to the new CirrusLabs container

haynar commented 1 year ago

Is there any chance this will be merged any time soon?

ThexXTURBOXx commented 1 year ago

@haynar Just use the dependency override as described for the time being

BodenTide commented 12 months ago

I used the import https://github.com/ThexXTURBOXx/catcher.git. It will report that the sentry library uses 7.2.0 and is incompatible with uuid: ^4.0.0. Can you help me?

ThexXTURBOXx commented 12 months ago

I am currently at a conference. I will see tomorrow if there is something I can do about it. Most likely, some dependency has a dependency conflict with another library that you use.

ThexXTURBOXx commented 12 months ago

@Guo2299 It is due to sentry: https://github.com/getsentry/sentry-dart/issues/1623 There is sadly nothing I can do about it for the time being. Try downgrading any other libraries in your project which depend on uuid 4.x

ThexXTURBOXx commented 11 months ago

@jhomlala Interested in me maintaining this plugin? You could add me as a collaborator. I am planning on releasing something like catcher_2 soon in order to keep this really important plugin properly maintained.

calcitem commented 11 months ago

Dear @jhomlala and community,

I want to express my support for @ThexXTURBOXx's initiative to maintain the Catcher project. As someone who has benefited greatly from this library, it's evident that it is an invaluable resource for the Flutter community. I've seen the pull request (#234) submitted by @ThexXTURBOXx, and I believe it provides essential updates and fixes that can enhance the project significantly.

I strongly encourage you, @jhomlala, to consider adding @ThexXTURBOXx as a collaborator on this project, given their commitment to updating it. Allowing passionate and active contributors like @ThexXTURBOXx to step in would be a win for everyone involved if you cannot manage the project for any reason.

Thank you for your time and consideration.

ThexXTURBOXx commented 11 months ago

Big news!

For anyone listening here: A few minutes ago, I have successfully released catcher_2 version 1.0.0-alpha.0. It contains all the changes that have been made in this PR over the months and even a few more. I expect some bugs to occurr since I cannot test anything on Apple-devices (I don't have any). And I am too lazy to test everything, so if you encounter bugs, feel free to report them here! Otherwise, thank you very much for the support and have a nice day!

jhomlala commented 10 months ago

Thank you so much for this @ThexXTURBOXx. I have been busy for couple of months due to personal life changes. During this time you have been doing amazing job with this PR.

I don't want to close this PR, because there's a lot of important fixes. I can't ask you for more, but if you could find some time and check if there's anything that I could bring to the catcher then I would be very happy.

ThexXTURBOXx commented 10 months ago

Welcome back @jhomlala! I think you have already fixed the most important issues. I will just continue maintaining my fork and if you find that there is anything that you want to include in your catcher package, feel free to cherry-pick! :)