jhonathanc / ps3netsrv-android

Android ps3netsrv
Other
25 stars 4 forks source link

[FR] Multiple folder selection #16

Open VinnyRadev opened 1 year ago

VinnyRadev commented 1 year ago

Is it possible to choose multiple folders on the device, not just a single folder? For example, I have a USB and NM card on my phone + internal storage, that can be used to store games.

jhonathanc commented 1 year ago

Sure. It will be a nice improvement. I will develop the feature to decrypt redump / 3k3y isos first, because I already started it. But as it's not so difficult, I'll queue this next. The C++ version has this feature and you only need a text file inside the selected folder of ps3netsrv with the other paths, but I think it will not fit to the Android version because of SAF (user always need to explicit allow the app to access the files). I will have to let the user select every path using SAF.

VinnyRadev commented 1 year ago

Amazing!

VinnyRadev commented 1 year ago

any eta for this feature ?

jhonathanc commented 1 year ago

Probably next week, because I'll be on vacation and I'll have time to expend on this.

VinnyRadev commented 1 year ago

thank your for your prompt answer! Enjoy your vacation @jhonathanc

jhonathanc commented 1 year ago

I changed the server "core" to accept multiple folders. I didn't change the interface of the "Settings" activity, so you will not be able to select multiple folders yet. Could you please test if the application is still working? I'm without my PS3 to test... If this works, the next commit will change the "Settings" interface and I'll draft a new release.

https://github.com/jhonathanc/ps3netsrv-android/releases/tag/0.5

VinnyRadev commented 1 year ago

When scanning for games it gives "ERROR: file not found" inside the APP. On PS3 it does NOT load/preview the games in the folder.

jhonathanc commented 1 year ago

I already fixed it (it's because I tried to reuse the settings from the previous versions, but it didn't work as I expected...), but I found a new problem: if the user have sub folders with the same name inside the "main folders" (and it will occurs for sure, because the standards of ps3netsrv), the app will only retrieve the files inside the first sub folder. I'm looking around to find a way to fix this. I already have a strategy and will try it tomorrow.

jhonathanc commented 1 year ago

@VinnyRadev I updated the apk, could you please test? You will need to setup the folders again. This version let's you select more than 1 folder.

Avoid files with the same name on folders, because if you have 2 or more files with the same name, it will read only the first it finds.

https://github.com/jhonathanc/ps3netsrv-android/releases/download/0.5/app-debug.apk

aldostools commented 1 year ago

I got this error about grant read only rights to folders on Android 13 Screenshot_20230911_073502.jpg

jhonathanc commented 1 year ago

I got this error about grant read only rights to folders on Android 13

I've created a new issue for this issue: #19.

VinnyRadev commented 1 year ago

apologies for the late response. @jhonathanc do you still need me to test the above apk ?

jhonathanc commented 1 year ago

No, I'll fix the permission bug first.