jhooda / google-cast-sdk

Automatically exported from code.google.com/p/google-cast-sdk
0 stars 0 forks source link

chrome.cast.media.LoadRequest has misleading property #174

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
when initializing a chrome.cast.media.LoadRequest object, one can pass a 
chrome.cast.media.MediaInfo instance as a constructor parameter.
there is also the corresponding property for the first parameter called "media" 
so you can construct the LoadRequest with no parameters and set the MediaInfo 
later.

What is the expected output? What do you see instead?
the property for the chrome.cast.media.MediaInfo instance should be called 
"mediaInfo" instead of "media" because "media" could be mixed up with a 
chrome.cast.media.Media object.

Please provide any additional information below.
as a positive example where it's made "right" is chrome.cast.media.MediaInfo. 
it has constructor parameters "contentId" and "contentType" and the 
corresponding properties do have the exact same names so it is obvious what 
their meaning is.

Original issue reported on code.google.com by p...@zattoo.com on 28 Feb 2014 at 1:53

GoogleCodeExporter commented 9 years ago
same problem is with this property: 
https://developers.google.com/cast/docs/reference/chrome/chrome.cast.media.Media
#media as opposed to 
https://developers.google.com/cast/docs/reference/chrome/chrome.cast.Session#med
ia.

it is referencing a MediaInfo object but is called "media" instead of 
"mediaInfo".

Original comment by p...@zattoo.com on 28 Feb 2014 at 2:03

GoogleCodeExporter commented 9 years ago
I'll file a bug for this and ask to have the name changed.

Original comment by shawns...@google.com on 1 Mar 2014 at 6:26

GoogleCodeExporter commented 9 years ago
great :)

Original comment by p...@zattoo.com on 3 Mar 2014 at 9:25