search

jhoogstraat / fast_barcode_scanner

A flutter plugin that allows your users to scan any type of barcode on iOS and Android
41 stars 53 forks source link

Implement camera switching #51

Open ikbendewilliam opened 2 years ago

ikbendewilliam commented 2 years ago

Fixed #4

ikbendewilliam commented 2 years ago

@Xazin Can you review again? The comments have been fixed

Xazin commented 2 years ago

@Xazin Can you review again? The comments have been fixed

@jhoogstraat Is the only one who can merge it, and he also needs to review it.

Also I think you should change the branch you're merging into to develop !

jhoogstraat commented 2 years ago

Yeah, sorry for being to quiet. I am finalizing my master thesis, so after that I will be back working on this plugin. Does this fix issues which are present in the develop branch?

Xazin commented 2 years ago

This is the missing functionality to switch between front and back camera, I am not sure how the develop branch looks, but this indeed does fix this part of the issue on main.

ikbendewilliam commented 2 years ago

No worries, that has priority of course! This adds functionality in the current release v1.1.4 (main branch). I haven't tested it on the v2 (develop branch)

ikbendewilliam commented 2 years ago

Hi @jhoogstraat, I hope you're doing well. In the near future we'd like to use this implementation in a new package, to publish that package this first needs to be merged. For now we use git dependencies 🙂. This isn't priority as you're working on your master thesis, but can you give us an indication of when you would be able to check this? Or, if you prefer, you could give @Xazin merge rights (or someone else ofc). But that's entirely up to you.

jhoogstraat commented 2 years ago

Hi, actually I am back right now. I am currently looking through all the comments and changes!

ikbendewilliam commented 2 years ago

Any update on this?

jhoogstraat commented 2 years ago

I would very much like to merge your pr, but I am still hestitent as I am unsure how to incorporate these changes into v2 (develop branch).

Maybe with a bit of refactoring this approach can be used.

ikbendewilliam commented 2 years ago

I'll try to take a look and see if we can make this compatible or I'll create a branch starting from this one and work on how to incorporate these changes in the next version

vanlooverenkoen commented 1 year ago

@jhoogstraat any idea when we can get this merged or when v2 will be done?

jhoogstraat commented 1 year ago

I think there is not much left for the release of v2. I'll do some tests and check with other issues/prs.

vanlooverenkoen commented 1 year ago

Thanks, we are looking forward to that so we can update our package and release them to pub.dev as well

vanlooverenkoen commented 1 year ago

@jhoogstraat any update on this?

ikbendewilliam commented 1 year ago

@jhoogstraat any more updates? 😁

jhoogstraat commented 11 months ago

Hey, I'll take at look at the code. Is this ready to merge?

vanlooverenkoen commented 11 months ago

We are using this in production for 1,5 years already

ikbendewilliam commented 11 months ago

Yes it's ready to merge and indeed, we've been using it in different projects that are in production

vanlooverenkoen commented 10 months ago

@jhoogstraat any idea when this can be merged?