search

jhpratt / num_threads

Obtain the number of threads in the current process
https://docs.rs/num_threads
Apache License 2.0
12 stars 7 forks source link

Update Rust version to build libc on Apple Silicon #20

Closed thibault-ml closed 9 months ago

thibault-ml commented 9 months ago

Tries to address #19

The current version of Rust being used to build is 1.28, which is nearly 5 years old.

This leads to libc not compiling on macOS (Apple Silicon) in the tests.

This change updates Rust to 1.76.0, the latest version as of the writing of this ticket.

jhpratt commented 9 months ago

1.28 is the MSRV. I have no issue bumping it, but it should be to the lowest version necessary to make things work as expected.

thibault-ml commented 9 months ago

@jhpratt fair enough. I used cargo msrv to determine the MSRV, which is 1.54.0.

Updated the PR to use 1.54.0

jhpratt commented 9 months ago

@Freaky Any objections?

Freaky commented 9 months ago

Nope. I'm particularly looking forward to our MSRV supporting MaybeUninit :)

jhpratt commented 9 months ago

Merging in that case! I'll let you take charge on using MaybeUninit and whatnot. I trust your judgement :slightly_smiling_face:

Oh, and the MSRV should be updated in docs.