jhpyle / docassemble

A free, open-source expert system for guided interviews and document assembly, based on Python, YAML, and Markdown.
https://docassemble.org
MIT License
778 stars 254 forks source link

Make "Sign up" & "Sign in" similar w/ login links #754

Closed BryceStevenWilley closed 5 months ago

BryceStevenWilley commented 7 months ago

When login link style is "normal" with a wide screen, the login links are styled differently: one as a plain, unmarked link, and one as a button. Screen shot of vanilla docassemble below:

Screenshot from 2024-03-09 15-34-36

While the aesthetic isn't bad, the usability suffers, as it's not clear either at a glace or when hovering, that "Sign up" is a clickable link. This gets worse when modifying the bootstrap theme (see https://github.com/mplp/docassemble-mlhframework/issues/87 for this original discussion, where it's more pronounced using our modified nav bar color).

This change makes the links consistent on narrow screens and on wide screens: either both links on narrow screens (in the dropdown) or both buttons on wider screens.

Additionally fixed an issue where there would be no login URL using login link style and not allowing registration.

Tested with login link style == "normal", and with allow registration as true and false.