jhqiu21 / pe

0 stars 0 forks source link

The NRIC format is in-consistency #11

Open jhqiu21 opened 1 week ago

jhqiu21 commented 1 week ago

Note that when the user input edit s1486256j i/s7495552e, the person whose NRIC is S1486256J will be changed to S7495552E, but in the list it still display as s7495552e instead of S7495552E, which makes NRIC inconsistent in format.

截屏2024-11-15 17.26.44.png

Similarly when enter edit s7495552e i/S7495552e, it will change to S7495552e.

截屏2024-11-15 17.33.46.png

soc-pe-bot commented 5 days ago

Team's Response

This was intended, we want the users to be able to choose what they want to display as the NRIC. It is possible that the user wants to have the NRIC alphabets displayed in lowercase, and forcing it to be displayed in uppercase might not be optimal for those users. Whether or not we should standardise this to uppercase will require some more discussion with the target user, which is not in the scope of the current project.

Furthermore, this is a minor UI issue, therefore the team feels that it should be VeryLow severity

Mentioned in the UG: 6185858435573203208.jpg

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I think although this bug may appear cosmetic at first glance, its implications may extend to functional correctness, and system reliability, which should be considered during implementation.


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Now I think this issue should be `severity.Low` as it is not just about format, it is about data consistency.