nus-se-bot
commented
1 week ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Invalid email address is allowed
When the user input an invalid email address, the system simply add the person with an invalid email address in the list instead of raising a error message.
For example input
add i/S5087089H n/John Doe p/98765432 e/123@45 a/John street, block 123, #01-01 c/7, the system will add the person.
This bug is a feature flaw as it will cause the inconvenience of the user and it will not raise a warning message, it needs users to check by themselves to find the error.
[original: nus-cs2103-AY2425S1/pe-interim#3375] [original labels: severity.Medium type.FeatureFlaw]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Under Planned Enhancements: Change validation of email: Currently, the email field is validated using a simple regex pattern. It might not be able to catch all invalid email addresses, and might reject some valid emails. We plan to change the validation to use a more robust email validation algorithm, based on this RFC 3696 standard.
We lowered the severity to Low since having more flexibility in the email validation is unlikely to affect normal operations of the product.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [x] I disagree
Reason for disagreement: This issue is not absolute a duplicate issue. As the 'original' bug emphasized on allow invalid email address, which could be modified later. But this issue is about valid email address can not be added, there is no another way for user to find a way to "bypass"(i.e. avoid) this bug.
## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** This issue will influence users' experience as they could not add a valid email address. They could not even find out why their valid format violate the format check in the user guide. Then they only have to set up another "valid email", which also may have "invalid" risk since the team did not state the constrain clearly in the user guide. Hence, this issue should not be rejected. But its type I think is `Document Bug` now.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** The severity should be Medium as this causes occasonal inconvenience to some users, but they can continue to use the product.
Note that when input
add i/S5087089H n/John Doe p/98765432 e/joh_.nd@example.com a/John street, block 123, #01-01 c/7, the system will report an email invalid message although the email addressjoh_.nd@example.comis valid.