jhqiu21 / pe

0 stars 0 forks source link

Pure number name is allowed #9

Open jhqiu21 opened 1 week ago

jhqiu21 commented 1 week ago

Note that a person's name should not be a number like 123, while the system allows this operation without any warning message.

Example: add i/S6878830G n/123 t/wheelchairUser e/betsycrowe@example.com a/Blk30 Geylang Street 28, #06-48 p/1234567 c/2

Expect: The system do not allow simply put only number at name field, or the system will raise a warning message when user input only number to inform them to check the name again.

截屏2024-11-15 17.17.52.png

nus-pe-script commented 5 days ago

Team's Response

We allowed the users to follow whatever naming convention/system they wanted. It is not a requirement for the name in ContactMate to follow the legal name of the elderly, as there is already identification done by the NRIC field. In addition, it is possible that our target user might have their own internal naming system, consisting of numbers. Whether or not we want to restrict the name validation to completely reject names only consisting of numbers will require further discussion with our target user, which is not in the current scope of the project.

We changed this to low as the product can still be used and in the rare event our target user unintentionally set the name to a number, it will not cause a lot of inconvenience for these reasons below:

image.png

  1. Feedback is given about what the user just added, it is easily noticeable and the elderly is easily editable.
  2. Having the name as a number is not harmful to the product in any way, (ie. it does not mess up the logic of ContactMate, nor is it required that the name follows the legal name of the elderly as explained above).

    Items for the Tester to Verify

    :question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]