Support for AIX 7.1 TL4.

jhrozek / pam_hbac

A simple pam account module to process HBAC rules stored on an IPA server

GNU General Public License v3.0

10 stars 9 forks source link

Support for AIX 7.1 TL4. #101

Closed johnnys66 closed 6 years ago

johnnys66 commented 7 years ago

Hi Jakub,

I finally got started with IPA on AIX. It's working with just a few changes.

Added function getgrset in get_user_groups to query the users groups, funcion getgrent in AIX does not query ldap, only nis and local.

jhrozek commented 7 years ago

I'm sorry I was silent about this PR for a whole month, but I was busy with work...

I'm really glad you found the time to contribute some more to pam_hbac! I have some comments and some questions, see the review of the PR. Please let me know if I should provide some patches you can squash in your branch to save you time.

johnnys66 commented 7 years ago

I think all your suggestions make sense. If you can provide the patches I'll be happy to test them.

jhrozek commented 7 years ago

OK, I pushed your patch along with one of mine that implements the option to avoid building man pages if you run configure with --disable-man-pages and another that I would like to squash into yours that mostly just checks allocation results and so on. But I didn't test the AIX codepath at all to be honest...but now I do have some access (albeit non-root) to an AIX machine, so hopefully I'll at least check out the groups-for-user branch.

jhrozek commented 7 years ago

And I forgot to say I pushed the new branch here: https://github.com/jhrozek/pam_hbac/tree/aix