search

jhshi / openofdm

Sythesizable, modular Verilog implementation of 802.11 OFDM decoder.
http://openofdm.rtfd.io
Apache License 2.0
367 stars 188 forks source link

Reserved bit in 802.11n should be 1 (instead of 0) #23

Open redfast00 opened 2 years ago

redfast00 commented 2 years ago

While doing my masters thesis, I came across the documentation for OpenOFDM. It states here (https://openofdm.readthedocs.io/en/latest/sig.html#fig-ht-sig) that the reserved bit should be 0, but according to the standard, it should be set to 1 (see 802.11n-2009 page 276). I could make a PR to fix this, but I don't know if there's any other place I should fix this in (the Verilog code maybe?)

Aside, I would really like to thank you for writing such clear documentation, it helped me a lot. Your blog post on the 802.11n CRC calculation in Python was also very useful, thank you!

jhshi commented 2 years ago

It's a reserved bit -- shouldn't matter if it's 0 or 1. Feel free to send a PR to fix it

redfast00 commented 1 day ago

This was fixed in #24, but was not deployed to https://openofdm.readthedocs.io/en/latest/sig.html yet. I thought Read the Docs would automatically do this, but I guess not.