jhthorsen / app-mojopaste

Pastebin
38 stars 19 forks source link

Tests fail with Mojolicious 6.37 #10

Closed eserte closed 8 years ago

eserte commented 8 years ago

The t/unicode.t test fails with the newest Mojolicious:

#   Failed test 'exact match for selector "pre"'
#   at t/unicode.t line 22.
Wide character in print at /usr/perl5.14.4/lib/site_perl/5.14.4/Test/Builder.pm line 1826.
#          got: 'BLACK DOWN-POINTING TRIANGLE :3'
#     expected: 'BLACK DOWN-POINTING TRIANGLE Σ'

#   Failed test 'exact match for content'
#   at t/unicode.t line 23.
Wide character in print at /usr/perl5.14.4/lib/site_perl/5.14.4/Test/Builder.pm line 1826.
#          got: 'BLACK DOWN-POINTING TRIANGLE :3'
#     expected: 'BLACK DOWN-POINTING TRIANGLE Σ'
# Looks like you failed 2 tests of 6.
t/unicode.t ...... 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/6 subtests

Statistical analysis (negative theta is bad):

****************************************************************
Regression 'mod:Mojolicious'
****************************************************************
Name                   Theta          StdErr     T-stat
[0='const']           1.0000          0.0000    116746645577737856.00
[1='eq_5.32']         0.0000          0.0000       4.58
[2='eq_5.79']         0.0000          0.0000       1.32
[3='eq_6.08']         0.0000          0.0000       5.73
[4='eq_6.09']         0.0000          0.0000       5.61
[5='eq_6.10']         0.0000          0.0000       6.32
[6='eq_6.11']         0.0000          0.0000       7.94
[7='eq_6.17']         0.0000          0.0000      11.22
[8='eq_6.19']         0.0000          0.0000       4.58
[9='eq_6.27']         0.0000          0.0000       5.29
[10='eq_6.31']        0.0000          0.0000       9.17
[11='eq_6.32']        0.0000          0.0000       9.17
[12='eq_6.33']        0.0000          0.0000       9.17
[13='eq_6.34']        0.0000          0.0000       9.17
[14='eq_6.36']        0.0000          0.0000       9.17
[15='eq_6.37']       -1.0000          0.0000    -101105560876939136.00

R^2= 1.000, N= 44, K= 16
****************************************************************
eserte commented 8 years ago

This might be the same problem as https://github.com/zoffixznet/Test-Mojo-Role-SubmitForm/issues/9 (Mojolicious & Unicode involved here, too).

jhthorsen commented 8 years ago

Will look at it around New Years.

eserte commented 8 years ago

Test suite of App-mojopaste-0.16 still fail with 6.37, but pass with 6.38 and newer. Statistical analysis:

****************************************************************
Regression 'mod:Mojolicious'
****************************************************************
Name                   Theta          StdErr     T-stat
[0='const']           1.0000          0.0000    9958677343214078.00
[1='eq_5.32']        -0.0000          0.0000      -0.27
[2='eq_6.02']         0.0000          0.0000       1.84
[3='eq_6.35']         0.0000          0.0000       1.02
[4='eq_6.37']        -1.0000          0.0000    -8131226001296701.00
[5='eq_6.38']         0.0000          0.0000       0.59
[6='eq_6.39']         0.0000          0.0000       0.91

R^2= 1.000, N= 41, K= 7
****************************************************************
jhthorsen commented 8 years ago

Sorry. Completely forgot about it. Going to follow up unless @zoffixznet has information already.

zoffixznet commented 8 years ago

This was a problem with Mojolicious itself, introduced in this commit https://github.com/kraih/mojo/commit/84a856c73820971ea78ff4014d8c3a3c331c85d3 and fixed in this one https://github.com/kraih/mojo/commit/129e3174fdcc63906563df173fdfd64d02abb94e#diff-4ba2033fc4980e7ae338b9e6cec4fb89 released in Mojolicious version 6.38

jhthorsen commented 8 years ago

Thank you!