Fixes and two new TLVs - Githubissues

jhthorsen / docsis-configfile

Perl module that decodes and encodes DOCSIS config-files

https://metacpan.org/release/DOCSIS-ConfigFile

11 stars 3 forks source link

Fixes and two new TLVs #2

Closed ddragic closed 11 years ago

ddragic commented 11 years ago

Creating a pull request, as suggested. These are the same patches as those at rt.cpan.org.

jhthorsen commented 11 years ago

I need a unit test for this, so It's not messed up later on. Suggestion: Add a test to 10-decode.t which tries to decode vendorspec with 0x0a. Make it fail first and then make sure your patch fix it. Let me know if you need assistance on how to extend the unittest.

Big +1 on making a pull request! Makes my life so much easier :)

ddragic commented 11 years ago

Added a unit test. The value is an encoding of a Cisco MPLS VPN route distinguisher vendor specific TLV. Without the patch the test fails with a confess from vendorspec, with the patch it passes.

jhthorsen commented 11 years ago

POSTing upload for DOCSIS-ConfigFile-0.64.tar.gz to https://pause.perl.org/pause/authenquery

New version is on it's way.