search

jhthorsen / homebridge-tasmota-aircon-http

Control Aircon through Tasmota HTTP commands
MIT License
4 stars 2 forks source link

Add switches for Quiet, Turbo and Eco mode #2

Closed macjl closed 2 years ago

macjl commented 2 years ago

Please review my code, as I'm not a developper !!

macjl commented 2 years ago

Hello,

Thank you for your feedbacks. I cleaned the code. Tell me if it's OK for you.

Regards,

macjl commented 2 years ago

I avec added a modification, to ensure that all switches aren't set to Off, when an automation put a switch to Off the is already in that state.

macjl commented 2 years ago

Hello, Do you think everything is clean now? Or did I miss something ?

jhthorsen commented 2 years ago

I would like to mention you as a author/contributor. If that is ok, then which name do you want me to use? Git log has your email, but I'm not sure how to translate that into your name.

macjl commented 2 years ago

Thank you I will check the tests this week-end. I don’t know how it works, that’s why I didn’t make anything on this before. For mentioning my contribution, you can use my real name : Jean-Laurent Girod

I also have some proposition for other improvements. I will open others issue for that.