jhthorsen / json-validator

:cop: Validate data against a JSON schema
https://metacpan.org/release/JSON-Validator
56 stars 58 forks source link

Undeclared dependencies? (t/jv-formats.t failures) #140

Closed eserte closed 5 years ago

eserte commented 5 years ago

Test suite fails on some of my smokers, probably if Data::Validate::Domain and/or Data::Validate::IP are not installed:

Data::Validate::Domain is not available: Can't locate Data/Validate/Domain.pm in @INC (you may need to install the Data::Validate::Domain module) (@INC contains: ...) at (eval 59) line 1.
Data::Validate::Domain is not available: Can't locate Data/Validate/Domain.pm in @INC (you may need to install the Data::Validate::Domain module) (@INC contains: ...) at (eval 59) line 1.

#   Failed test 'errors: /v: Does not match hostname format.'
#   at t/Helper.pm line 37.
#     Structures begin differing at:
#          $got->[0] = Does not exist
#     $expected->[0] = HASH(0x460ff138)
# []
Data::Validate::IP is not available: Can't locate Data/Validate/IP.pm in @INC (...) at (eval 60) line 1.
Data::Validate::IP is not available: Can't locate Data/Validate/IP.pm in @INC (...) at (eval 60) line 1.

#   Failed test 'errors: /v: Does not match ipv4 format.'
#   at t/Helper.pm line 37.
#     Structures begin differing at:
#          $got->[0] = Does not exist
#     $expected->[0] = HASH(0x460f7f00)
# []
Data::Validate::IP is not available: Can't locate Data/Validate/IP.pm in @INC (...) at (eval 61) line 1.
Data::Validate::IP is not available: Can't locate Data/Validate/IP.pm in @INC (...) at (eval 61) line 1.

#   Failed test 'errors: /v: Does not match ipv6 format.'
#   at t/Helper.pm line 37.
#     Structures begin differing at:
#          $got->[0] = Does not exist
#     $expected->[0] = HASH(0x41cf5ba0)
# []
Format rule for 'unknown' is missing at /home/cpansand/.cpan/build/2019010510/JSON-Validator-3.00-6ccqee/blib/lib/JSON/Validator.pm line 705.
# Looks like you failed 3 tests of 35.
t/jv-formats.t ......................... 
Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/35 subtests 
jhthorsen commented 5 years ago

Thanks for the report! This should be fixed in 3.01.