search

jhthorsen / json-validator

:cop: Validate data against a JSON schema
https://metacpan.org/release/JSON-Validator
56 stars 58 forks source link

Add more tests for bundle() #159

Closed karenetheridge closed 5 years ago

karenetheridge commented 5 years ago

These are all the tests I was using for my implementation of bundle(), including a few interesting cases of name duplication, recursive references, etc. All of my test cases are now implemented by bundle as of version 3.11, so hooray :)

jhthorsen commented 5 years ago

@karenetheridge: What's the status of this PR? I'll probably accept it and fix up the comments myself, if this PR is idling for much longer. (That means that I will be credited via "git blame" on many lines after running through perltidy)

karenetheridge commented 5 years ago

I plan to come back to this next week.

On Sat, Jun 1, 2019 at 2:20 AM Jan Henning Thorsen notifications@github.com wrote:

@karenetheridge https://github.com/karenetheridge: What's the status of this PR? I'll probably accept it and fix up the comments myself, if this PR is idling for much longer. (That means that I will be credited via "git blame" on many lines after running through perltidy)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mojolicious/json-validator/pull/159?email_source=notifications&email_token=AACJ7SYH7PKDSWKTH4V3YF3PYI5MVA5CNFSM4HNGZAF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWW4RYY#issuecomment-497928419, or mute the thread https://github.com/notifications/unsubscribe-auth/AACJ7SZHUNGDD67Q6QYKUCDPYI5MVANCNFSM4HNGZAFQ .

karenetheridge commented 5 years ago

I've force-pushed some changes.

jhthorsen commented 5 years ago

Sorry, I missed out on the tidying. Thanks for the improved tests 👍