Closed chorny closed 4 years ago
So, it appears (from inferring from the patch provided) that infinite recursion is occuring because two paths are being compared case-sensitively on a case-insensitive filesystem, and they should match but they do not. Where in the tests is that happening? That is, where are two paths provided that are identical-except-for-case?
This also provides a hint for writing a demonstration test -- one could perhaps hack CASE_TOLERANT so it is the same value across all platforms (for this one test), and demonstrate how behaviour is different with and without the lc
.
I'm also curious where the path comparison is taking place, such that lower-casing is necessary -- because lc
is not necessarily the right thing to do here, given various locales' handling of case. When comparing strings, foldcase (fc
) is preferred.
I'm going to close this, since it seems like @charsbar is not interested in this anymore.
@jhthorsen , well maybe it was @chorny not me, but anyway, I sent a modified version of this PR #180
That was a bad autocomplete from me. Sorry about that 😢
So it would be lowercase and match